Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More editorial fixes #473

Merged
merged 2 commits into from
May 30, 2023
Merged

More editorial fixes #473

merged 2 commits into from
May 30, 2023

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented May 24, 2023

Final round of fixes based on chats with @jyasskin


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 25, 2023, 6:30 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@npm1 npm1 requested a review from samuelgoto May 24, 2023 22:37
@@ -1775,8 +1776,6 @@ rendering of this image is performed by the user agent, and as such this image c
## Sec-Fetch-Dest Header ## {#sec-fetch-dest-header}
<!-- ============================================================ -->

*This section is non-normative.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This section does not seem to have any conformance requirements, instead just talking about things that follow from other specifications.

Also, github does not let me seem to comment on it, but line 1784 has a grammar error -- "must to check" should probably be "must check". Is this the normative part of this section? That seems a bit subtle.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this subsection is not special, so we either have none of them be non-normative or all of them (and note it at the section, not within each subsection). Also, done (changed to needs to check)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section does not seem to have any conformance requirements

Isn't this a conformance requirement for IdPs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have conformance requirements for IDPs. See #471

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Show resolved Hide resolved
spec/index.bs Show resolved Hide resolved
spec/index.bs Show resolved Hide resolved
@@ -1775,8 +1776,6 @@ rendering of this image is performed by the user agent, and as such this image c
## Sec-Fetch-Dest Header ## {#sec-fetch-dest-header}
<!-- ============================================================ -->

*This section is non-normative.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section does not seem to have any conformance requirements

Isn't this a conformance requirement for IdPs?

spec/index.bs Show resolved Hide resolved
@samuelgoto samuelgoto merged commit 03a49d1 into main May 30, 2023
@samuelgoto samuelgoto deleted the registeredFix branch May 30, 2023 16:20
github-actions bot added a commit that referenced this pull request May 30, 2023
SHA: 03a49d1
Reason: push, by samuelgoto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request May 31, 2023
SHA: 03a49d1
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants